Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request UI: Missing Hover / No Action On Click #5074

Closed
hediet opened this issue Jul 14, 2023 · 3 comments · Fixed by #5075
Closed

Pull Request UI: Missing Hover / No Action On Click #5074

hediet opened this issue Jul 14, 2023 · 3 comments · Fixed by #5075
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2023

Comments

@hediet
Copy link
Member

hediet commented Jul 14, 2023

Code_-_Insiders_4VM2ZEecFP
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jul 18, 2023
@alexr00 alexr00 transferred this issue from microsoft/vscode Jul 18, 2023
@alexr00 alexr00 added this to the July 2023 milestone Jul 18, 2023
@alexr00 alexr00 mentioned this issue Jul 18, 2023
Merged
alexr00 added a commit that referenced this issue Jul 18, 2023
@alexr00
Pull Request UI: Missing Hover / No Action On Click
f173103 
Fixes #5074
alexr00 added a commit that referenced this issue Jul 18, 2023
@alexr00
Pull Request UI: Missing Hover / No Action On Click (#5075)
97d2db1 
Fixes #5074
@hediet
Copy link
Member Author

hediet commented Jul 25, 2023 •
edited
Loading

While there is an action on click, I think the hover could say what it means or what would happen when I click on it.
Maybe "Change reviewers" would do it.

Showing a hover just for the icon is confusing, as it is unrelated to the click action:

Code_-_Insiders_ZFTzErhX5q

Also, the icon alignment is off.

@hediet hediet reopened this Jul 25, 2023
@alexr00
Copy link
Member

alexr00 commented Jul 25, 2023

Icon alignment will be fixed by #5101, as will the not helpful hover for the icon.

@hbons
Copy link
Member

hbons commented Jul 26, 2023

Fixes have been merged.

@hbons hbons closed this as completed Jul 26, 2023
@mjbvz mjbvz added the verified Verification succeeded label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2023
Development

Successfully merging a pull request may close this issue.

Pull Request UI: Missing Hover / No Action On Click microsoft/vscode-pull-request-github
4 participants
@hbons @hediet @mjbvz @alexr00