Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11y avatar fixes #5101

Merged
merged 4 commits into from
Jul 25, 2023
Merged

A11y avatar fixes #5101

merged 4 commits into from
Jul 25, 2023

Conversation

hbons
Copy link
Member

@hbons hbons commented Jul 24, 2023

Fix a few things:

  • Remove the links around the avatars, which clashes with the click event for the whole list (when trying to open QuickPick).
  • Hide elements to VoiceOver that are decoration or not useful.
  • Add user's full name on hover over users

@hbons hbons requested a review from alexr00 July 24, 2023 15:23
alexr00
alexr00 requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than my one comment. I'll push a change to the PR with a fix.

webviews/components/user.tsx Show resolved Hide resolved
This was referenced Jul 25, 2023
Closed
Closed
alexr00
alexr00 requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes as suggestions! You should be able to accept my suggestions then I'll approve!

webviews/createPullRequestViewNew/app.tsx Outdated Show resolved Hide resolved
webviews/createPullRequestViewNew/app.tsx Outdated Show resolved Hide resolved
webviews/components/user.tsx Outdated Show resolved Hide resolved
@alexr00 alexr00 mentioned this pull request Jul 25, 2023
Closed
@hbons hbons enabled auto-merge (squash) July 25, 2023 14:25
@hbons hbons requested a review from alexr00 July 25, 2023 14:30
@hbons hbons merged commit 50868d7 into main Jul 25, 2023
2 checks passed
@hbons hbons deleted the a11y-avatar-fixes branch July 25, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@hbons hbons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbons @alexr00