Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an inline action for adding label/milestone/etc? #5109

Closed
connor4312 opened this issue Jul 25, 2023 · 3 comments
Closed

Have an inline action for adding label/milestone/etc? #5109

connor4312 opened this issue Jul 25, 2023 · 3 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@connor4312
Copy link
Member

Testing #5100

I've been using the new PR flow in VS Code for a while and honestly never noticed the extra buttons for assigning metadata. It is also slightly weird that the action happens in the title and then causes an effect elsewhere in the body. Maybe there could be inline actions kind of like this to add them?

image

@alexr00 alexr00 added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 26, 2023
@alexr00 alexr00 added this to the August 2023 milestone Jul 26, 2023
@alexr00 alexr00 modified the milestones: August 2023, On Deck Aug 23, 2023
@hbons
Copy link
Member

hbons commented Dec 4, 2023

I like this idea. Is there already a button like this in VS Code? I do wonder if this will make the form too cluttered and maybe there's something we else we can do instead of adding 4 buttons.

@hbons
Copy link
Member

hbons commented Dec 5, 2023

GitHub web does have this:
image

@alexr00
Copy link
Member

alexr00 commented Dec 14, 2023

Closing as out of scope. We only need one way to let users set reviewers/labels/etc.

@alexr00 alexr00 closed this as completed Dec 14, 2023
@alexr00 alexr00 added the *out-of-scope Posted issue is not in scope of VS Code label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants