Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to self assign #5116

Closed
karthiknadig opened this issue Jul 25, 2023 · 10 comments · Fixed by #5574
Closed

Provide a way to self assign #5116

karthiknadig opened this issue Jul 25, 2023 · 10 comments · Fixed by #5574
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded

Comments

@karthiknadig
Copy link
Member

Testing #5100

@hbons
Copy link
Member

hbons commented Jul 26, 2023

You mean you want a dedicated entry in the Assignee quick pick that says "Self Assign"?

@alexr00
Copy link
Member

alexr00 commented Jul 26, 2023

We also have a setting "githubPullRequests.assignCreated": "${user}"

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Jul 26, 2023
@karthiknadig
Copy link
Member Author

You mean you want a dedicated entry in the Assignee quick pick that says "Self Assign"?

Yes.

@alexr00 alexr00 added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Jul 27, 2023
@alexr00 alexr00 added this to the Backlog milestone Jul 27, 2023
@hbons
Copy link
Member

hbons commented Dec 4, 2023

I think this is a good idea. @alexr00 how about Assign Yourself as the first item followed by a separator? This is the same wording as on GH web.

@alexr00 alexr00 modified the milestones: Backlog, December 2023 Dec 5, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@alexr00 alexr00 added this to the December / January 2024 milestone Dec 11, 2023
@alexr00
Copy link
Member

alexr00 commented Dec 20, 2023

image

alexr00 added a commit that referenced this issue Dec 20, 2023
alexr00 added a commit that referenced this issue Dec 20, 2023
@alexr00
Copy link
Member

alexr00 commented Jan 22, 2024

To verify:

  • Install the pre-release version of GitHub Pull Requests and Issues
  • Open the description/overview of a PR Checkout a topic branch, make a commit, and run the command "Create Pull Request"
  • Add an assignee from the "Create" view. Verify that you see an "Assign yourself" option at the top of the quick pick.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Jan 22, 2024
@andreamah andreamah added the verified Verification succeeded label Jan 23, 2024
@andreamah
Copy link

image I don't think I see it. Does it need to be my own PR?

@andreamah andreamah reopened this Jan 23, 2024
@andreamah andreamah added verification-found Issue verification failed and removed verified Verification succeeded labels Jan 23, 2024
@karthiknadig
Copy link
Member Author

I see this:
image

And I see my self as the first option:
image

@alexr00
Copy link
Member

alexr00 commented Jan 24, 2024

My verification steps were incorrect:

  • Install the pre-release version of GitHub Pull Requests and Issues
  • Open the description/overview of a PR Checkout a topic branch, make a commit, and run the command "Create Pull Request"
  • Add an assignee from the "Create" view. Verify that you see an "Assign yourself" option at the top of the quick pick.

@alexr00 alexr00 closed this as completed Jan 24, 2024
@alexr00 alexr00 removed the verification-found Issue verification failed label Jan 24, 2024
@aiday-mar
Copy link
Contributor

aiday-mar commented Jan 24, 2024

Just verified, it works:

Screenshot 2024-01-24 at 13 00 22

Although I see myself twice in that list now (the third account is a test account)

@aiday-mar aiday-mar added the verified Verification succeeded label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants