Fix regression with workdir symlinks #1053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment in #580 (comment)
While upgrading from vsce 2.3 to 3.1, I had this regression which prevented building my package.
I use the following
package.json
extract:And this folder is a symlink.
If a workdir was refering a symlink directory, we would pass it to yazl, which would error out because it's a directory.
glob recommends using
follow: true
to consider directory symlinks as directories in the collection.