-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak in terminal support #111562
Comments
I'm not seeing this happen in local VS code windows - only remote. Is that what you're seeing too @solomatov ? |
@meganrogge I had it in both cases, but in case of the remote it was showing much faster, but your version, and configuration is likely different from mine. |
This bug has been fixed in to the latest release of VS Code Insiders! @solomatov, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text Happy Coding! |
(includes from 4.9.0) Diff: xtermjs/xterm.js@3504e2e...master Fixes microsoft#108400 Fixes microsoft#111562
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: No
I investigated why it happened, and root caused it to a memory leak in xterm.js
It's possible to work around this issue by getting a buffer once, on xterm object creation, and using this object instead of a terminal.buffer. I checked, and it fixed the above problem. The memory consumption is stable, and vs code doesn't die.
The text was updated successfully, but these errors were encountered: