cache buffer to fix VS Code issue #111562 #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
changed the title
mofux
reviewed
Jan 4, 2021
Comment on lines
+62
to
+65
| if (!this._buffer) { | ||
| return new BufferNamespaceApi(this._core.buffers); | ||
| } | ||
| return this._buffer; |
There was a problem hiding this comment.
I think this fix doesn't work because this._buffer is never assigned. I think it should have been:
if (!this._buffer) {
this._buffer = new BufferNamespaceApi(this._core.buffers);
}
return this._buffer;There was a problem hiding this comment.
yes you're absolutely correct. i'll create another pull request now to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/vscode#111562