Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: remember terminal layout between restarts #112338

Closed
3 tasks done
meganrogge opened this issue Dec 11, 2020 · 1 comment
Closed
3 tasks done

Test: remember terminal layout between restarts #112338

meganrogge opened this issue Dec 11, 2020 · 1 comment

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Dec 11, 2020

Refs #109244

Complexity: 4

Authors: @roblourens, @meganrogge

Create Issue


For reference, https:/microsoft/vscode-internalbacklog/issues/1555 was the test plan item for remote terminal reconnection in general.

Action:
Open a remote VS Code window and create tabs of split terminals. Reload the window.

Expectation: the following persists:

  • active tab
  • for each tab, the active instance
  • the relative widths (horizontal) or heights (vertical) of the terminals in a tab

Some things to try:

  1. The terminal state is restored correctly when the terminal is hidden while reloading the window. Try revealing the terminal:
    • using the command / keybinding
    • by dragging it
  2. Re-orient the terminal panel to be vertical instead of horizontal
  3. Multi-folder
    • Open folder A
    • Open 3 terminals in a split tab
    • Open folder B (in the same window)
    • Run the command “Terminal: Attach to session”
    • Pick one of those terminals, kill it
    • Open folder A again
    • See that the 2 remaining terminals are restored and are split with reasonable sizing
@joaomoreno
Copy link
Member

joaomoreno commented Jan 26, 2021

@meganrogge That was an epic battle against the bot. It didn't even let you have the last word!

@joaomoreno joaomoreno removed their assignment Jan 26, 2021
@mjbvz mjbvz removed their assignment Jan 26, 2021
@deepak1556 deepak1556 removed their assignment Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants