Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment range highlighting not removed when user closes(Collapse) comment widget #148216

Closed
IllusionMH opened this issue Apr 26, 2022 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@IllusionMH
Copy link
Contributor

IllusionMH commented Apr 26, 2022

Issue Type: Bug

Testing #148048

  1. Select multiple lines and click on + in gutter - selection in replaced with highlighted range
  2. Click on Collapse button instead of adding comment - highlighting stays in place until user tried to add new comment or switches editors. Highlighting stays even if user edits file (inside and outside of highlighted range)

Looks confusing at this point, but maybe it would allow to click on + on the last line of selection to add comment?

  1. Click on + for last line of highlighted range - highlighting is gone and selection will be added for single line.

image

VS Code version: Code - Insiders 1.67.0-insider (ab86e02, 2022-04-26T05:15:54.133Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.50GB (16.02GB free)
Process Argv --crash-reporter-id 19aedffb-5c29-4248-9110-b5b20040c42f
Screen Reader no
VM 0%
Extensions (25)
Extension Author (truncated) Version
vscode-tomcat ada 0.12.1
toggle-excluded-files eam 1.7.0
tsl-problem-matcher amo 0.6.2
vscode-css-modules and 1.2.3
markdown-preview-github-styles bie 1.0.1
vscode-eslint dba 2.2.3
gitlens eam 12.0.6
EditorConfig Edi 0.16.4
LogFileHighlighter emi 2.15.0
vscode-pull-request-github Git 0.41.2022042609
vscode-drawio hed 1.6.4
rest-client hum 0.24.6
vscode-postfix-ts ipa 1.9.4
fluent-icons mig 0.0.17
vscode-docker ms- 1.22.0
remote-ssh ms- 0.78.0
remote-ssh-edit ms- 0.80.0
remote-wsl ms- 0.66.0
hexeditor ms- 1.9.6
js-debug-nightly ms- 2022.4.2217
live-server ms- 0.2.12
test-adapter-converter ms- 0.1.6
vscode-jest Ort 4.4.0
material-icon-theme PKi 4.16.0
markdown-pdf yza 1.4.4
@IllusionMH
Copy link
Contributor Author

/assign @alexr00

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Apr 27, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 27, 2022
@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2022

Can repro. 👍

Even repro when the comment is deleted.

alexr00 added a commit that referenced this issue Apr 27, 2022
@meganrogge meganrogge added the verified Verification succeeded label Apr 29, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@joaomoreno @IllusionMH @meganrogge @alexr00 and others