Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiline comments #148048

Closed
3 tasks done
alexr00 opened this issue Apr 25, 2022 · 0 comments
Closed
3 tasks done

Test multiline comments #148048

alexr00 opened this issue Apr 25, 2022 · 0 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 25, 2022

Refs: #146510

Complexity: 3

Create Issue


The comments API has always supported multiline comments, but we didn't show whether multiline comments are multiline in the editor. If you know of another extension that provides multiline comments, please test with that otherwise you can use the GitHub Pull Requests and Issues extension to test:

  1. Install the pre-release version of GitHub Pull Requests and Issues.
  2. Open a folder with a GitHub repository where you can comment on pull requests.
  3. Make or open a pull request.

Verify

  • that you can figure out how to leave multiline comments.
  • that while your leaving a multiline comment you can tell what lines it's on.
  • that you can see which line an existing multiline comment is on.
  • that you can tell in the Comments view that a comment is multiline.
  • that single line comments don't any text highlight or border color (no change in how single line comments are indicated in this iteration).
  • that hovering or focusing the comment widget for a multiline comment causes added emphasis to be placed on the comment's range.
  • that you can change the theme colors for the editor decorations for multiline comments (colors are editorCommentsWidget.rangeBackground, editorCommentsWidget.rangeBorder, editorCommentsWidget.rangeActiveBackground, editorCommentsWidget.rangeActiveBorder).
@alexr00 alexr00 added this to the April 2022 milestone Apr 25, 2022
@karthiknadig karthiknadig removed their assignment Apr 26, 2022
@joaomoreno joaomoreno removed their assignment Apr 27, 2022
@sana-ajani sana-ajani removed their assignment Apr 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants