Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in drawing decorations for comments #148268

Closed
joaomoreno opened this issue Apr 27, 2022 · 0 comments
Closed

Inconsistency in drawing decorations for comments #148268

joaomoreno opened this issue Apr 27, 2022 · 0 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
April 2022

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Apr 27, 2022 •
edited
Loading

Testing #148048

Related to #148266

A single-line comment only seems to get a decoration if its selection contains the first character in the line. Why not always draw a decoration, despite whether I pick the entire line or otherwise?

Recording 2022-04-27 at 15 53 16 (1)
@alexr00 alexr00 added under-discussion Issue is under discussion for relevance, priority, approach comments Comments Provider/Widget/Panel issues bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Apr 27, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 27, 2022
@meganrogge meganrogge added the verified Verification succeeded label Apr 29, 2022
aeschli pushed a commit that referenced this issue May 2, 2022
@alexr00 @aeschli
Fix single line comment ranges
0b336d1 
Fixes #148268
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
April 2022
Development

No branches or pull requests
4 participants
@joaomoreno @meganrogge @alexr00 and others