Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't access comment actions when space is too narrow #148279

Closed
joaomoreno opened this issue Apr 27, 2022 · 10 comments
Closed

Can't access comment actions when space is too narrow #148279

joaomoreno opened this issue Apr 27, 2022 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #148048

image

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Apr 27, 2022
@alexr00 alexr00 added this to the April 2022 milestone Apr 27, 2022
@meganrogge
Copy link
Contributor

I wonder if the font size should shrink when it's this narrow so the text doesn't get cut off?
Screen Shot 2022-04-29 at 9 52 56 AM

@meganrogge
Copy link
Contributor

After doing the above, I expanded and pressed the up arrow with no text in the comment field. Now I'm in a state in which I can't get the decoration to go away and there isn't an associated item in the comments panel
Screen Shot 2022-04-29 at 9 54 37 AM

@meganrogge meganrogge added the verified Verification succeeded label Apr 29, 2022
@meganrogge
Copy link
Contributor

the original bug is fixed though

@alexr00
Copy link
Member

alexr00 commented May 2, 2022

@meganrogge did you try moving your cursor? The + should go away when the cursor is no longer on that line.

aeschli pushed a commit that referenced this issue May 2, 2022
@meganrogge
Copy link
Contributor

@alexr00
Copy link
Member

alexr00 commented May 2, 2022

Huh, in that gif I see the + go away when you click elsewhere. Am I looking at the wrong thing?

@meganrogge
Copy link
Contributor

I expected the white decoration to go away. Is that not what we want?

@alexr00
Copy link
Member

alexr00 commented May 2, 2022

The decoration with the + (marked by a yellow circle below) should go away, the narrow rectangle that indicates a commenting range (a portion of which is marked by a yellow rectangle) should not go away.

image

@meganrogge
Copy link
Contributor

meganrogge commented May 2, 2022

Yes the + disappears. Why do the white lines remain when there is no comment there?

@alexr00
Copy link
Member

alexr00 commented May 3, 2022

The white lines indicate that there is an extension which supports commenting on that range.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@joaomoreno @meganrogge @alexr00 and others