Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment + gutter icon is always showing when hovering over lines #149176

Closed
willresen opened this issue May 10, 2022 · 7 comments · Fixed by #152983
Closed

Comment + gutter icon is always showing when hovering over lines #149176

willresen opened this issue May 10, 2022 · 7 comments · Fixed by #152983
Assignees
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@willresen
Copy link

Issue Type: Bug

I am not sure if this was something I accidentally enabled, but it looks like it appeared with the latest VSCode version. Hovering over lines now shows a + symbol in the gutter, and it's highly distracting. Is this a bug, or can it be disabled?

VS Code version: Code 1.67.0 (57fd6d0, 2022-05-04T12:06:02.889Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info
Item Value
CPUs AMD Ryzen 7 2700X Eight-Core Processor (16 x 3700)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.95GB (22.27GB free)
Process Argv --open-url -- vscode://ms-vsliveshare.vsliveshare/join?vslsLink=https://vscode.dev/liveshare/7C1825ACABA1D08656F2471E6AA22B4F0283
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
vsc-material-theme Equ 33.2.0
vsc-material-theme-icons equ 1.2.2
prettier-vscode esb 9.5.0
copilot Git 1.19.5865
gc-excelviewer Gra 4.2.54
vsliveshare ms- 1.0.5561
material-theme zhu 3.13.25

(5 theme extensions excluded)

@willresen
Copy link
Author

unknown_2022.05.10-13.29.mp4

@rebornix rebornix assigned alexr00 and unassigned rebornix May 10, 2022
@alexr00 alexr00 added feature-request Request for new features or functionality comments Comments Provider/Widget/Panel issues labels May 11, 2022
@alexr00 alexr00 modified the milestones: Backlog Candidates, June 2022 May 11, 2022
@alexr00
Copy link
Member

alexr00 commented May 11, 2022

@willresen The "+" on line hover indicates that you can leave an extension comment on that line. We used to only show the "+" when you hovered over the gutter itself, but now we show it over the whole line so that it's easier to find.

This means that you have an extension installed that let's you leave comments in files. The extension might have a way for you to disable this.

I would like to add a feature to VS Code that just disables all commenting. Assigning to June to work on this.

@willresen
Copy link
Author

willresen commented May 11, 2022

@alexr00, great to know, thank you. i'll see if I can figure out what the extension is and will disable it in the meantime. it's very distracting - can you consider an option that preserves the old symbol behavior where it is only displayed when hovering in the gutter? comments are useful but there is now too much distracting movement on screen. it also shows in Zen mode which I believe is counter productive.

@alexr00
Copy link
Member

alexr00 commented May 12, 2022

it also shows in Zen mode which I believe is counter productive.

Good point, this should be disabled in Zen mode.

@joaomoreno
Copy link
Member

@alexr00 Bit more thoughts on this:

Maybe a setting wouldn't be the right fit for this, since a user might forget that it set it and forget about it... or worse, it could be set at workspace level and the user never even knew it was set.

Maybe runtime UI state would work best since it isn't as sticky. Additionally, it would be great if there is some indication that comments are indeed hidden as opposed to the current file not having any comments at all. What do you think?

@alexr00
Copy link
Member

alexr00 commented Jun 13, 2022

Additionally, it would be great if there is some indication that comments are indeed hidden as opposed to the current file not having any comments at all. What do you think?

Having some indication that there are comments, they're just hidden, makes sense. We should do this.

Maybe runtime UI state would work best since it isn't as sticky

We can start with some runtime UI state and add a setting later if there's a desire for it.

alexr00 added a commit that referenced this issue Jun 23, 2022
alexr00 added a commit that referenced this issue Jun 23, 2022
alexr00 added a commit that referenced this issue Jun 23, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
comments Comments Provider/Widget/Panel issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@joaomoreno @rebornix @alexr00 @willresen @vscodenpa and others