Test disabling editor commenting

[alexr00]

Refs: #149176

• anyOS @TylerLeonhardt
• anyOS @brettcannon

Complexity: 3

Create Issue

---

1. Install an extension that provides comments, such as GitHub Pull Requests and Issues and get into a state where there are some comments and commenting ranges.
   a. If you're using GitHub Pull Requests and Issues, then you can checkout a pull request and leave some comments to get into a good state for testing
2. Run the "Comments: Toggle Editor Commenting Command" and verify:
   a. that all commenting UX (commenting ranges and comment widgets) is removed from all editors
   b. that you can toggle commenting back on
   c. that if you open the comments view and click on a comment that the comment will show in the editor
3. Toggle commenting back on, toggle zen mode on and verify:
   a. that editor commenting is off by default in zen mode
   b. that you can toggle editor commenting on in zen mode

[TylerLeonhardt]

Works exactly as expected :)

[brettcannon]

that if you open the comments view and click on a comment that the comment will show in the editor

Is this expected to jump to the line where the comment would be, or should the comment be forcibly turned on?

I also noticed that the line didn't jump back into view if I scrolled it out of view. Is that expected?

[alexr00]

@brettcannon that should have been fixed in the insiders build from yesterday (clicking on a comment in the view toggles commenting back on). Were you on that build?

[brettcannon]

I've verified I'm on v0.45.2022062909 today. I thought I checked there wasn't an update, but I was also admittedly exhausted yesterday, very possibly PEBKAC. 😅

Only thing I'm now seeing is two clicks are required to bring a line into view and then to show the comment.

I'm assuming that's on purpose or some design limitation, so I'm closing as LGTM!

[alexr00]

2 clicks is not expected, but I'm not able to reproduce it. What OS are you using?

[brettcannon]

Windows 11

[alexr00]

The 2 click happens when the extension that provides the comment initially provides it in a collapsed state. Maybe by design, maybe unexpected. #153924