Mongoid HEAD Compatibility #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,6 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_dependency "rails-observers", "~> 0.1.2" | |||
There was a problem hiding this comment.
This gem entirely depends on rails-observers. Remove this line, the gem user needs to add this gem manually in their Gemfile.
There was a problem hiding this comment.
Ah, that reflects a misunderstanding on my part---I thought adding it to the gem's Gemfile would be sufficient. Looks like its maintainers will need to be prodded for a fresh release.
|
@phyllisstein, can you make the build pass? do you know when mongoid 6 is going to release? |
|
Not sure what the release timeline is, but I'll definitely keep working on getting the tests green again when I can! With any luck I'll have some time this week to look at it. |
|
According to Mongoid JIRA, release in May 2017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependency on
rails-observersand tests the Mongoid functionality against Mongoid HEAD (v6). Bumping these dependencies will facilitate work on digitalplaywright/mongoid-slug to add compatibility for Mongoid 6.