Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mongoid_slug:set rake task for Mongoid 5. [DON'T MERGE] #218

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Jun 8, 2016

Need to make sure the mongoid HEAD build passes, right now there're some issues with mongoid/observers, see mongoid/mongoid-observers#2.

@dblock dblock changed the title fix: mongoid_slug:set rake task for Mongoid 5. Fix: mongoid_slug:set rake task for Mongoid 5. [DON'T MERGE] Jun 8, 2016
@Fudoshiki
Copy link
Contributor

Fudoshiki commented Jun 9, 2016

#216 Tests against mri 2.3.1, rails 5.0.0.rc1

@Fudoshiki
Copy link
Contributor

Fudoshiki commented Jun 9, 2016

@dblock want we target master branch at Mongoid HEAD?

@dblock
Copy link
Collaborator Author

dblock commented Jun 9, 2016

Yes @Fudoshiki, but generally I am not too excited about trying to keep up with mongoid until there's some RC or something. Of course I'd take pull requests if someone is motivated to use the edge version(s).

@Fudoshiki
Copy link
Contributor

Fudoshiki commented Jun 9, 2016

@dblock
Can we drop Mongoid 4/5 and ruby < 2.2.2 support in master branch?

@dblock
Copy link
Collaborator Author

dblock commented Jun 10, 2016

@Fudoshiki I'd like not to, unless we must because we just can't make it work.

@Fudoshiki
Copy link
Contributor

ok

@Fudoshiki
Copy link
Contributor

Fudoshiki commented Jun 11, 2016

@dblock We can close this

dblock added a commit that referenced this pull request Jun 11, 2016
Mongoid HEAD support, PR #218 included [READY TO MERGE]
@dblock
Copy link
Collaborator Author

dblock commented Jun 11, 2016

Closing in favor of #219 .

@dblock dblock closed this Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants