Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongoid HEAD support, PR #218 included #219

Merged
merged 1 commit into from Jun 11, 2016
Merged

Mongoid HEAD support, PR #218 included #219

merged 1 commit into from Jun 11, 2016

Conversation

Fudoshiki
Copy link
Contributor

@Fudoshiki Fudoshiki commented Jun 11, 2016

#218
Still in progress, failing 2 tests

@Fudoshiki
Copy link
Contributor Author

@dblock any ideas about?

  1) mongoid_slug:set when models parameter is passed goes though all documents of passed models and sets slug if not already set
     Failure/Error: const != const.upcase ? Mongoid::Slug > (Object.const_get const) : nil

     TypeError:
       compared with non class/module
     # ./lib/tasks/mongoid_slug.rake:6:in `>'
     # ./lib/tasks/mongoid_slug.rake:6:in `block (3 levels) in <top (required)>'
     # ./lib/tasks/mongoid_slug.rake:5:in `each'
     # ./lib/tasks/mongoid_slug.rake:5:in `find_all'
     # ./lib/tasks/mongoid_slug.rake:5:in `block (2 levels) in <top (required)>'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:248:in `block in execute'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:243:in `each'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:243:in `execute'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:187:in `block in invoke_with_call_chain'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:180:in `invoke_with_call_chain'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:173:in `invoke'
     # ./spec/tasks/mongoid_slug_rake_spec.rb:41:in `block (3 levels) in <top (required)>'
  2) mongoid_slug:set when models parameter is not passed goes though all documents and sets slug if not already set
     Failure/Error: const != const.upcase ? Mongoid::Slug > (Object.const_get const) : nil

     TypeError:
       compared with non class/module
     # ./lib/tasks/mongoid_slug.rake:6:in `>'
     # ./lib/tasks/mongoid_slug.rake:6:in `block (3 levels) in <top (required)>'
     # ./lib/tasks/mongoid_slug.rake:5:in `each'
     # ./lib/tasks/mongoid_slug.rake:5:in `find_all'
     # ./lib/tasks/mongoid_slug.rake:5:in `block (2 levels) in <top (required)>'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:248:in `block in execute'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:243:in `each'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:243:in `execute'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:187:in `block in invoke_with_call_chain'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:180:in `invoke_with_call_chain'
     # /home/travis/.rvm/gems/ruby-2.3.1/gems/rake-11.2.0/lib/rake/task.rb:173:in `invoke'
     # ./spec/tasks/mongoid_slug_rake_spec.rb:68:in `block (3 levels) in <top (required)>'

@Fudoshiki
Copy link
Contributor Author

@dblock Do we need mongoid 3 support? We can remove mongoid-compability if will drop mongoid 3

@dblock
Copy link
Collaborator

dblock commented Jun 11, 2016

This looks great. Can I merge? Want to squash it?

@Fudoshiki
Copy link
Contributor Author

Fudoshiki commented Jun 11, 2016

@dblock Wait build pass and merge, i will rebase it

@Fudoshiki
Copy link
Contributor Author

@dblock Complete!

@Fudoshiki Fudoshiki changed the title [WIP] Mongoid HEAD support, PR #218 included [Don't merge] [WIP] Mongoid HEAD support, PR #218 included [Ready to merge] Jun 11, 2016
@Fudoshiki Fudoshiki changed the title [WIP] Mongoid HEAD support, PR #218 included [Ready to merge] Mongoid HEAD support, PR #218 included [Ready to merge] Jun 11, 2016
@Fudoshiki Fudoshiki changed the title Mongoid HEAD support, PR #218 included [Ready to merge] Mongoid HEAD support, PR #218 included [READY TO MERGE] Jun 11, 2016
@dblock
Copy link
Collaborator

dblock commented Jun 11, 2016

Excellent work @Fudoshiki

@dblock dblock merged commit 6a7af04 into mongoid:master Jun 11, 2016
@Fudoshiki Fudoshiki changed the title Mongoid HEAD support, PR #218 included [READY TO MERGE] Mongoid HEAD support, PR #218 included Jun 11, 2016
@dblock
Copy link
Collaborator

dblock commented Sep 11, 2016

FYI was released in 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants