-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mongoid HEAD support, PR #218 included #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2016
@dblock any ideas about?
|
@dblock Do we need mongoid 3 support? We can remove mongoid-compability if will drop mongoid 3 |
This looks great. Can I merge? Want to squash it? |
@dblock Wait build pass and merge, i will rebase it |
@dblock Complete! |
Fudoshiki
changed the title
[WIP] Mongoid HEAD support, PR #218 included [Don't merge]
[WIP] Mongoid HEAD support, PR #218 included [Ready to merge]
Jun 11, 2016
Fudoshiki
changed the title
[WIP] Mongoid HEAD support, PR #218 included [Ready to merge]
Mongoid HEAD support, PR #218 included [Ready to merge]
Jun 11, 2016
Fudoshiki
changed the title
Mongoid HEAD support, PR #218 included [Ready to merge]
Mongoid HEAD support, PR #218 included [READY TO MERGE]
Jun 11, 2016
Excellent work @Fudoshiki |
Fudoshiki
changed the title
Mongoid HEAD support, PR #218 included [READY TO MERGE]
Mongoid HEAD support, PR #218 included
Jun 11, 2016
FYI was released in 5.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#218
Still in progress, failing 2 tests