[Bug]: Orientation lock after launching from external intents from PiP

[czlucius]

Steps to reproduce

1. Play a video in a tab, in landscape mode
2. Open it in fullscreen
3. Use the home button/navigation controls to navigate to the Android home screen, so that the video continues in Picture in Picture mode.
4. On the home screen, rotate to portrait mode
5. Launch an app shortcut (long click on Firefox icon and select New Tab or New private tab)
6. Enter a website into the address bar (e.g. https://mozilla.org)

Expected behaviour

On step 6, the website should open in portrait mode

Actual behaviour

The app rotates to landscape mode, and the user cannot switch to portrait mode even if the phone is in the portrait orientation. The user cannot go back to portrait mode unless he goes to the tab playing the video and exit fullscreen mode.

Device name

Samsung Galaxy S20 FE 5G

Android version

Android 11

Firefox release type

Firefox

Firefox version

94.1.2

Device logs

No response

Additional information

Screen recording below illustrates the issue.

video_2021-11-17_13-29-04.mp4

This is related to #18727, which is already closed

┆Issue is synchronized with this Jira Task

[SoftVision-LorandJanos]

Hi @czlucius! Thank you for your report!
I've managed to reproduce the issue you described.

Tested on:

• latest Nightly (96.0a1. 2021-11-17).
• latest Beta (95.0.0-beta4).
• latest Release (94.1.2).

Device used: Xiaomi Mi11 (Android 11).

[czlucius]

Thanks

I think this problem was not discovered when I added my fix to fenix few months ago.
See this PR: #20486

[czlucius]

I'd like to work on this issue.
Will push a PR soon.

[Mugurell]

I could not reproduce on a Pixel 3 with Android 12.
@czlucius @SoftVision-LorandJanos Can the STRs be distilled a bit more? Is this an intermittent issue? Are there other steps needed? Does it seems device specific?

PipToMozilla.mp4

[czlucius]

I just tried on my device, seems like the bug is no longer reproducible.
I used the same device listed above, but updated to Android 12.

[czlucius]

New steps to reproduce:

1. Launch a YouTube video
2. Go to the home screen
3. Launch Fenix from the search widget (not from the app shortcuts)

Note that this may not be a problem with PiP because this happens regardless of whether the video was playing at Step 1.

Thanks.

[Mugurell]

Thank you @czlucius!
Interestingly the above scenario will crash the app for me most of the times - created #24040 to address this.

Other than your above steps a scenario that would lead to the described issue:

• have a website shortcut added to homescreen
• play a fullscreen video, enter pip
• tap to open the website shortcut from device's homescreen.

The problem I think is somewhere in the AC's MediaSessionFullscreenFeature which seems to set screen orientation more often than expected and in some scenarios not the orientation that we'd want.

[Mugurell]

There is a similar issue for when using custom tabs - #25413 but with the crash from #24040 now being resolved resolved I think we can close this.

[LaurentiuApahideanSV]

I tested the issue on Firefox nightly 103.0a1 2022-06-08 and can confirm the issue is fixed.

Devices used:

• Google Pixel 6 (Android 13)
• OnePlus 6T (Android 9)