Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fenix issue when coming from PIP: Video is halved. #24039

Closed
Mugurell opened this issue Mar 1, 2022 · 3 comments
Closed

Fenix issue when coming from PIP: Video is halved. #24039

Mugurell opened this issue Mar 1, 2022 · 3 comments
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Mar 1, 2022

Seen on all Release 97, Beta 98, Nightly 99 (and also on Focus after the PIP integration)
Originally opened a ticket on Bugzilla - https://bugzilla.mozilla.org/show_bug.cgi?id=1757031 since this seems like a GeckoView issue but with the other recent tickets Irelated to fullscreen and screen orientation maybe there is something to improve on Fenix/AC also.

STRs:

Expected result:

  • Video is not in fullscreen anymore but do extend to the available GV layout bounds in the app.

Actual result:

  • Video is halved (seems like it's width in landscape still occupys what would be screen width while in portrait) but GV does occupy the full width of the screen.
  • Also saw another case in which the video is not halved but just smaller - the black bars are larger, maybe such that it would entirely fit the screen, while otherwise it would have to extend to a bit below the visible screen.
  • A scroll in the page will have the video immediately take the expected dimensions.
GvVideoFraming.mp4

┆Issue is synchronized with this Jira Story

@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 1, 2022
@Mugurell
Copy link
Contributor Author

Mugurell commented Mar 1, 2022

Saw in #22471 that MediaSessionFullscreenFeature might have some issues for certain scenarios, maybe we could also double check our fullscreen/setting orientation functionality separately from GeckoView.

@Mugurell Mugurell added the eng:qa:needed QA Needed label May 6, 2022
@Mugurell
Copy link
Contributor Author

Mugurell commented May 6, 2022

This should be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1757031

@Mugurell Mugurell added this to the 102 milestone May 6, 2022
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 102.0a1 (2022-05-06) build.
Devices used:

  • Samsung Galaxy Tab S3 (Android 9).
  • Google Pixel 4 (Android 12).
    Closing the ticket as fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants