Handle storage get failure #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compile. This was the original behavior of sccache, but I believe it regressed sometime during the tokio refactor.
…ing S3 response body. Also log response body size regardless, for forensic sanity checks.
|
👍 |
|
I think we just hit this in rust-lang/rust at https://travis-ci.org/rust-lang/rust/jobs/231599352
I'm updating to sccache's master branch now so we can get the better logging from this. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
May 12, 2017
This commit updates the sccache binaries to fix a cache load failure seen on rust-lang#41926, fixed by mozilla/sccache#119
|
Yeah, that's the same error I had seen in Firefox CI:
This patch will make it non-fatal, although I'd love to figure out what the root cause is. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
May 13, 2017
Update sccache binaries to mozilla/sccache@d3627d766 This commit updates the sccache binaries to fix a cache load failure seen on #41926, fixed by mozilla/sccache#119
Xanewok
added a commit
to Xanewok/sccache
that referenced
this pull request
Dec 8, 2021
* cargo fix --edition * move to rust 2021 * feat: add msrv to cargo manifest * Revert "cargo fix --edition" This reverts commit 1046c457bd41fb61d664ec24f2bd0f9bb1b71cec. * Use some other new Rust 2021 features * Use my correct e-mail in the Cargo.toml Co-authored-by: Bernhard Schuster <[email protected]> Co-authored-by: Igor Matuszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing failures reading cache entries in Firefox CI. I'm not sure if we're getting a truncated response from S3 or what, but it's failing to parse the zip file. This change makes storage failures like that non-fatal, they're just handled as cache misses. I believe this was the original behavior of sccache and it got changed during the tokio refactor.
I've also added another change to check that the response body matches the
Content-Lengthheader for S3 requests, and a diagnostic log for the response body in all cases.