Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box large variants in MIR #41926

Merged
merged 1 commit into from
May 12, 2017
Merged

box large variants in MIR #41926

merged 1 commit into from
May 12, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented May 11, 2017 •
edited
Loading

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

cc #36799 (@urschrei - does ostn15_phf compile with this PR?)

r? @eddyb

@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 11, 2017
@arielb1
box large variants in MIR
c85501b 
Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
@eddyb
Copy link
Member

eddyb commented May 11, 2017

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2017

📌 Commit c85501b has been approved by eddyb

@urschrei
Copy link
Contributor

@arielb Will this be in tonight's Nightly? (assuming the tests pass)
If not, I might need someone to point me at some docs for building and compiling without rustup…

@nagisa
Copy link
Member

nagisa commented May 11, 2017

It won’t be in tonight’s nightly, no. Building rustc from source is described in the readme.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41926 - arielb1:box-mir, r=eddyb
67fd0bd 
box large variants in MIR

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

cc rust-lang#36799 (@urschrei - does ostn15_phf compile with this PR?)

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41926 - arielb1:box-mir, r=eddyb
b93dfec 
box large variants in MIR

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

cc rust-lang#36799 (@urschrei - does ostn15_phf compile with this PR?)

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
@urschrei
Copy link
Contributor

urschrei commented May 12, 2017 •
edited
Loading

using rustc 1.19.0-dev (141e8a6 2017-05-12):
ostn15_phf unoptimised: 155.5 secs
ostn15_phf release: 129.1 secs

lonlat_bng also builds.

I'm on MacOS, so I can't easily look at peak memory usage…

cc @arielb1

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 12, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#41926 - arielb1:box-mir, r=eddyb
9b19970 
box large variants in MIR

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

cc rust-lang#36799 (@urschrei - does ostn15_phf compile with this PR?)

r? @eddyb
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 12, 2017
Closed
@arielb1
Copy link
Contributor Author

arielb1 commented May 12, 2017

I want perf stats. Let's merge this out of rollup

@bors p=100

@bors
Copy link
Contributor

bors commented May 12, 2017

⌛ Testing commit c85501b with merge ac46f79...

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 12, 2017
@bors
Copy link
Contributor

bors commented May 12, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

  • sccache error

ERROR:sccache::server: [Error(Msg("Failed to parse cache entry"), State { next_error: Some(InvalidArchive("Could not find central directory end")) })] HexagonSplitDouble.cpp.o

Fixed by mozilla/sccache#119

I'll prepare some new builds

alexcrichton added a commit to alexcrichton/rust that referenced this pull request May 12, 2017
@alexcrichton
Update sccache binaries to mozilla/sccache@d3627d766
c30e007 
This commit updates the sccache binaries to fix a cache load failure seen
on rust-lang#41926, fixed by mozilla/sccache#119
@alexcrichton alexcrichton mentioned this pull request May 12, 2017
Merged
@alexcrichton
Copy link
Member

PR for that fix: #41955

@bors
Copy link
Contributor

bors commented May 12, 2017

⌛ Testing commit c85501b with merge e17a122...

bors added a commit that referenced this pull request May 12, 2017
@bors
Auto merge of #41926 - arielb1:box-mir, r=eddyb
e17a122 
box large variants in MIR

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?

cc #36799 (@urschrei - does ostn15_phf compile with this PR?)

r? @eddyb
@bors
Copy link
Contributor

bors commented May 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing e17a122 to master...

@bors bors merged commit c85501b into rust-lang:master May 12, 2017
bors added a commit that referenced this pull request May 13, 2017
@bors
Auto merge of #41955 - alexcrichton:update-sccache, r=eddyb
d5f1cfd 
Update sccache binaries to mozilla/sccache@d3627d766

This commit updates the sccache binaries to fix a cache load failure seen
on #41926, fixed by mozilla/sccache#119
@dwrensha dwrensha mentioned this pull request May 13, 2017
Merged
@michaelwoerister
Copy link
Member

Discussed in the compiler team meeting and accepted for backporting. @arielb1 will kindly take care of it.

@michaelwoerister michaelwoerister added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2017
@nikomatsakis nikomatsakis mentioned this pull request May 23, 2017
Open
@arielb1 arielb1 mentioned this pull request May 24, 2017
Merged
bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of #42197 - arielb1:box-mir-beta, r=nikomatsakis
4644612 
[beta] box large variants in MIR

Beta backport of #41926.

Operand: 72 -> 24 B
Statement: 192 -> 96 B
Terminator: 256 -> 112 B
librustc translation memory usage: 1795 -> 1669 MB

next step would be interning lvalues, I suppose?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arielb1 @eddyb @bors @urschrei @nagisa @alexcrichton @michaelwoerister @shepmaster