Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new IBuildProvider and ITransformProvider to unify esbuild provider options #286

Merged
merged 8 commits into from
Dec 21, 2022

Conversation

mrgrain
Copy link
Owner

@mrgrain mrgrain commented Dec 19, 2022

BREAKING CHANGE: buildFn, transformFn as wel as esbuildBinaryPath and esbuildModulePath have been replaced with a unified interface. Configure the default EsbuildProvider for more options or provide a custom implementation as an escape hatch.

BREAKING CHANGE: props.copyDir now removes the destination directory and any containing files if it exists. This will only affect edge cases when an asset has already been bundled and re-bundling is forced. Previously the destination directory would not have been cleared out, leading to outdated files being included in the bundle or an error message in same cases. The previous behavior was not correct and cannot be restored.

…provider options

BREAKING CHANGE: `buildFn`, `transformFn` as wel as `esbuildBinaryPath` and `esbuildModulePath` have been replaced with a unified interface.
Configure the default `EsbuildProvider` for more options or provide a custom implementation as an escape hatch.
@mrgrain mrgrain marked this pull request as ready for review December 21, 2022 19:08
@mergify mergify bot merged commit f60ab8e into main Dec 21, 2022
@mergify mergify bot deleted the provider-interface branch December 21, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant