Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces 3.1.0 #151

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Workspaces 3.1.0 #151

merged 6 commits into from
Jul 28, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Jul 27, 2022

  • worskpaces 3.1.0 with sandbox 0.0.12
  • createAndDeploy replaced with devDeploy
  • macos tests turned off because of sandbox issue (@ChaoticTempest , who is responsible for fixing it? Can we at least tag them, this issue affecting us a lot).
  • tests refactored

@volovyks volovyks requested a review from ailisp as a code owner July 27, 2022 09:54
@volovyks volovyks marked this pull request as draft July 27, 2022 09:57
@volovyks volovyks changed the title Workspaces 3.0.0 Workspaces 3.1.0 Jul 27, 2022
@volovyks volovyks marked this pull request as ready for review July 27, 2022 15:47
@volovyks volovyks requested a review from BenKurrek July 27, 2022 15:48
@volovyks
Copy link
Collaborator Author

@BenKurrek can I ask you to test this branch in M1. Just clone it and run the tests.

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Am i right that the sandbox on a local Mac is working, but just doesn't work on github ci?

@volovyks
Copy link
Collaborator Author

Looks great! Am i right that the sandbox on a local Mac is working, but just doesn't work on github ci?

Yes!

@volovyks volovyks merged commit 73d6f59 into develop Jul 28, 2022
@ChaoticTempest
Copy link
Member

the issue is here near/nearcore#7235, but so far no one is working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants