Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node crashes in macOS GitHub actions test workflow due to std::time inconsistency #7235

Closed
ChaoticTempest opened this issue Jul 21, 2022 · 2 comments

Comments

@ChaoticTempest
Copy link
Member

ChaoticTempest commented Jul 21, 2022

Describe the bug
The near node crashes when running on the macos-latest platform within Github Actions workflow. The backtrace can be found in the workspaces-rs test branch. It's caused from PeerManagerActor::update_routing_table_trigger when calling into self.clock.now() - PRUNE_UNREACHABLE_PEERS_AFTER. This panic is only happening in Github Actions, and regularly works on the ubuntu instance of GithubActions, and also on a local macOS computer (x86 and M1).

To Reproduce
Run neard on Github Actions macos-latest. A crash should occur pointing PeerManagerActor::update_routing_table_trigger.

Or just fork off the branch from https:/near/workspaces-rs/tree/test/non-deterministic-tests since that's already pulling in the nearcore binary with macos-latest.

Expected behavior
Does not crash the node with overflow

Version

  • nearcore master/13a66dda709a4148f6395636914dca2a55df1390
  • localnet/sandbox

Additional context
Found related issue in rust-lang/rust#48980 where this panic is platform specific, so not sure if there's a straightforward solution to this.

@volovyks
Copy link

Can we prioritize this issue? We are forced to disable macOS tests in Workspaces JS, RS, SDK JS, and all the projects that will use Workspaces tests.

@matklad
Copy link
Contributor

matklad commented Aug 9, 2022

closed by #7341

@matklad matklad closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants