Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more pytests #43

Merged
merged 13 commits into from
Jun 9, 2022
Merged

Even more pytests #43

merged 13 commits into from
Jun 9, 2022

Conversation

clewis7
Copy link
Collaborator

@clewis7 clewis7 commented Jun 6, 2022

adding in tests for cnmfe full using ground truth comparison

still need to create some ground truths for testing passing different ixs_components to get_spatial_contours(), get_spatial_masks()...will work on and then update ground truths file on zenodo!!

Copy link
Collaborator

@kushalkolar kushalkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kushalkolar
Copy link
Collaborator

when you're done can you just lint and I'll merge

@clewis7
Copy link
Collaborator Author

clewis7 commented Jun 9, 2022

ran linter

have finished tests for passing ixs_components to cnmf extensions

I believe tests should be all finished, unless there is something else you want me to write!!

@kushalkolar kushalkolar merged commit 8b08aa1 into dev Jun 9, 2022
@kushalkolar kushalkolar mentioned this pull request Jun 10, 2022
kushalkolar added a commit that referenced this pull request Jun 10, 2022
@kushalkolar kushalkolar added this to the v0.1 milestone Jul 3, 2022
@kushalkolar kushalkolar deleted the even-more-pytests branch November 8, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants