making caiman.run() common extension callbacks_finished arg optional #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clewis7 thanks! You'll also have to change the code around here to something like |
kushalkolar
requested changes
Jun 9, 2022
kushalkolar
approved these changes
Jun 9, 2022
| @@ -217,14 +217,16 @@ def get_temporal_components( | |||
| # TODO: Cache this globally so that a common upper cache limit is valid for ALL batch items | |||
| @validate("cnmf") | |||
| def get_reconstructed_movie( | |||
| self, ixs_frames: Tuple[int, int] = None, add_background: bool = True | |||
| self, | |||
| ixs_frames: Optional[Tuple[int, int], int] = None, | |||
There was a problem hiding this comment.
also tests are failing because this is wrong typing syntax, I think this is the correct syntax if you have multiple optional types:
Optional[Union[Tuple[int, int], int]]…ssed to get_reconstructed_movie()
kushalkolar
requested changes
Jun 10, 2022
| @@ -487,6 +487,57 @@ def test_cnmf(): | |||
| cnmf_max_actual = numpy.load(ground_truths_dir.joinpath("cnmf", "cnmf_std.npy")) | |||
| numpy.testing.assert_array_equal(cnmf_max, cnmf_max_actual) | |||
|
|
|||
| # test to check passing optional ixs components to various functions | |||
There was a problem hiding this comment.
what's with all the tests stuff in this PR/branch?
There was a problem hiding this comment.
I think it's because you merged that other branch into dev perhaps, and then I pulled new changes into my dev and then rebased this branch to align with dev perhaps...I'm not sure why it did that honestly
|
goodluck on the linalg test, don't worry about the code review until then! |
kushalkolar
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue #23
made
callbacks_finishedarg optional, should no longer cause problem of having to input arg forcallbacks_finishedasprint[]when running function in jupyter lab!!