Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong debug/release path of plugins #3345

Closed
superboyiii opened this issue Jun 17, 2024 · 3 comments · Fixed by #3320
Closed

Wrong debug/release path of plugins #3345

superboyiii opened this issue Jun 17, 2024 · 3 comments · Fixed by #3320
Assignees

Comments

@superboyiii
Copy link
Member

Describe the bug
An issue from #3306
I think it doesn't make sense. In currently solution, it generates all dependency dll in /bin but not ./bin

Microsoft Windows [Version 10.0.19045.4529]
(c) Microsoft Corporation. All rights reserved.

E:\PR-test\neo-pR#3311\neo\src\Plugins\ApplicationLogs>dotnet publish
MSBuild version 17.9.6+a4ecab324 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  Neo.VM -> E:\bin\Neo.VM\Release\net8.0\Neo.VM.dll
  Neo.Cryptography.BLS12_381 -> E:\bin\Neo.Cryptography.BLS12_381\Release\net8.0\Neo.Cryptography.BLS12_381.dll
  Neo.ConsoleService -> E:\bin\Neo.ConsoleService\Release\net8.0\Neo.ConsoleService.dll
  Neo.Extensions -> E:\bin\Neo.Extensions\Release\net8.0\Neo.Extensions.dll
  Neo.IO -> E:\bin\Neo.IO\Release\net8.0\Neo.IO.dll
  Neo.Json -> E:\bin\Neo.Json\Release\net8.0\Neo.Json.dll
  Neo -> E:\bin\Neo\Release\net8.0\Neo.dll
  Neo.Extensions -> E:\bin\Neo.Extensions\Release\net8.0\Neo.Extensions.dll
  Neo.Cryptography.BLS12_381 -> E:\bin\Neo.Cryptography.BLS12_381\Release\net8.0\Neo.Cryptography.BLS12_381.dll
  Neo.Json -> E:\bin\Neo.Json\Release\net8.0\Neo.Json.dll
  Neo.VM -> E:\bin\Neo.VM\Release\net8.0\Neo.VM.dll
  Neo.IO -> E:\bin\Neo.IO\Release\net8.0\Neo.IO.dll
  Neo -> E:\bin\Neo\Release\net8.0\Neo.dll
  RpcServer -> E:\bin\Neo.Plugins.RpcServer\Release\net8.0\RpcServer.dll
  ApplicationLogs -> E:\bin\Neo.Plugins.ApplicationLogs\Release\net8.0\ApplicationLogs.dll
  ApplicationLogs -> E:\bin\Neo.Plugins.ApplicationLogs\Release\net8.0\publish\

E:\PR-test\neo-pR#3311\neo\src\Plugins\ApplicationLogs>dotnet build
MSBuild version 17.9.6+a4ecab324 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  Neo.Json -> E:\bin\Neo.Json\Debug\net8.0\Neo.Json.dll
  Neo.ConsoleService -> E:\bin\Neo.ConsoleService\Debug\net8.0\Neo.ConsoleService.dll
  Neo.Cryptography.BLS12_381 -> E:\bin\Neo.Cryptography.BLS12_381\Debug\net8.0\Neo.Cryptography.BLS12_381.dll
  Neo.VM -> E:\bin\Neo.VM\Debug\net8.0\Neo.VM.dll
  Neo.Extensions -> E:\bin\Neo.Extensions\Debug\net8.0\Neo.Extensions.dll
  Neo.IO -> E:\bin\Neo.IO\Debug\net8.0\Neo.IO.dll
  Neo -> E:\bin\Neo\Debug\net8.0\Neo.dll
  Neo.Cryptography.BLS12_381 -> E:\bin\Neo.Cryptography.BLS12_381\Debug\net8.0\Neo.Cryptography.BLS12_381.dll
  Neo.Extensions -> E:\bin\Neo.Extensions\Debug\net8.0\Neo.Extensions.dll
  Neo.Json -> E:\bin\Neo.Json\Debug\net8.0\Neo.Json.dll
  Neo.IO -> E:\bin\Neo.IO\Debug\net8.0\Neo.IO.dll
  Neo.VM -> E:\bin\Neo.VM\Debug\net8.0\Neo.VM.dll
  Neo -> E:\bin\Neo\Debug\net8.0\Neo.dll
  RpcServer -> E:\bin\Neo.Plugins.RpcServer\Debug\net8.0\RpcServer.dll
  ApplicationLogs -> E:\bin\Neo.Plugins.ApplicationLogs\Debug\net8.0\ApplicationLogs.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:08.87

To Reproduce
Steps to reproduce the behavior:

  1. Got to any plugin folder path
  2. Run dotnet build or dotnet publish

Expected behavior
Generate all dependency in ./bin

Screenshots
image

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 17, 2024

Check *.csproj file to see. This was fixed already.

image

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 17, 2024

AND CMD works fine too

git pull works wonders

image

@superboyiii
Copy link
Member Author

#3320 does fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants