Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Path and Property for *.csproj files #3306

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jun 8, 2024

Change Log

  • Changed Pathing
  • Changed from BaseOutputPath to OutputPath cause of a dotnet CLI bug

Wasn't able to use just the *.csproj files to build or publish files (on linux).

closes #3305

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 requested a review from a team June 8, 2024 06:31
@cschuchardt88 cschuchardt88 added bug Used to tag confirmed bugs critical Issues (bugs) that need to be fixed ASAP waiting for review labels Jun 8, 2024
@shargon shargon removed the critical Issues (bugs) that need to be fixed ASAP label Jun 8, 2024
@vncoelho
Copy link
Member

This is an example why we URGENT need #3256

Without neo-cli being built we can not merge any other PR, this is insane.

@NGDAdmin NGDAdmin merged commit efbdc94 into neo-project:master Jun 14, 2024
8 checks passed
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 14, 2024
* master:
  Fixed pathing and Property (neo-project#3306)
  [Neo CLI New Feature] Allow custom plugins (neo-project#3295)
  Return expect to verify neo-cli (neo-project#3318)
  [Neo CLI Optimization] fix exception message (neo-project#3314)
  fix plugin download url (neo-project#3329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local build fails on master branch at 38cc0e9
5 participants