Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load raw suite2p data #81

Closed
wants to merge 332 commits into from
Closed

Load raw suite2p data #81

wants to merge 332 commits into from

Conversation

lauraporta
Copy link
Member

No description provided.

lauraporta and others added 16 commits April 20, 2023 14:48
* Add code to pool directions

* Add notes

* Cleanup

* Fix broken tests

* Recalculate outputs

* Update manifest and pyproject

* Fix package name

* Update package links

* Update dependencies

* Add more descriptions

* Edit pyproject file

* Expand readme with more details on the analysis

* Add docstring

* Test if we can see the schema in the readme file

* Update docstring

* Insert correct image

* Linting

* Apply suggestions from code review

Co-authored-by: Niko Sirmpilatze <[email protected]>

* Change prompt message

* Adjust input params of method get_median_subtracted_response_and_params

* Renaming and other small suggested fixes

* Small fixes

* Move out the method to make gaussian matrices

* Clean up

---------

Co-authored-by: Niko Sirmpilatze <[email protected]>
* Add code to pool directions

* Add notes

* Cleanup

* Fix broken tests

* Recalculate outputs

* Update manifest and pyproject

* Fix package name

* Update package links

* Update dependencies

* Add more descriptions

* Edit pyproject file

* Expand readme with more details on the analysis

* Add docstring

* Test if we can see the schema in the readme file

* Add handling of multiple days

* Improve performance to deal with very large files, from O(n ^2) to O(1)

* Delete commented code

* Handle fit fails

* Save the data in a given folder

* Skip ROIs that do not fit

* Add missing fit handling in sftf analysis

* Regenerate mock data according to new "day" values

* Update docstring

* Remove big chunk of duplicated code

* Test image in readme file

* Remove image

* Apply suggestions from code review

Co-authored-by: Niko Sirmpilatze <[email protected]>

* Change prompt message

* Adjust input params of method get_median_subtracted_response_and_params

* Renaming and other small suggested fixes

* Renaming 2

* Small fixes

* Move out the method to make gaussian matrices

* Clean up

* Add tests for multiple days and add more structure and comments regarding creation of mock data

* Update readme

* Small updates in the docs

* Simplify fitting methods according to discussion

* Improve description on dataset creation optimization

* Remove unused config

* Rearrange methods in generate mock data

* Renaming ad adding new fixture

* Add missing n_roi fixture calls

* Renaming and folder reorganization

* Remove try-catch construct

* Linting

* Add missing adjustments

* Add readme file with a description of the regression tests

* Add more descriptions / docs

* Revert readme change

* Fix usage of conftest

* Linting

---------

Co-authored-by: Niko Sirmpilatze <[email protected]>
Co-authored-by: Niko Sirmpilatze <[email protected]>
Co-authored-by: Joe Ziminski <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Change commit hash

* Revert "Change commit hash"

This reverts commit b1aa762.

* Add changes introduced by cruft

* Getting rid of the docs for now

* Remove sphinx docs action for now

* Include coverage for codecov action

* Test fixing check-manifest error
Co-authored-by: Niko Sirmpilatze <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@lauraporta lauraporta added the enhancement New feature or request label Aug 7, 2023
@lauraporta lauraporta added this to the Load raw suite2p output milestone Aug 7, 2023
@lauraporta lauraporta linked an issue Aug 7, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #81 (966229d) into main (b1a7e73) will decrease coverage by 3.45%.
The diff coverage is 8.88%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   77.49%   74.04%   -3.45%     
==========================================
  Files          14       16       +2     
  Lines         773      809      +36     
==========================================
  Hits          599      599              
- Misses        174      210      +36     
Files Changed Coverage Δ
rsp_vision/load/load_data.py 0.00% <0.00%> (ø)
rsp_vision/load/load_raw_suite2p_data.py 0.00% <0.00%> (ø)
rsp_vision/load/load_stimulus_info.py 0.00% <0.00%> (ø)
rsp_vision/objects/photon_data.py 85.32% <ø> (-0.08%) ⬇️
rsp_vision/objects/folder_naming_specs.py 57.89% <50.00%> (+0.75%) ⬆️
rsp_vision/objects/data_raw.py 63.93% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be sure to integrate 3p data correctly
2 participants