Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Cats Effect 2 instrumentation with Finest log level #1173

Merged
merged 4 commits into from
May 15, 2023

Conversation

mbszarek
Copy link
Contributor

@mbszarek mbszarek commented Mar 3, 2023

Before contributing, please read our contributing guidelines and code of conduct.

Overview

In one of previous PRs somebody introduced an info log in CE 2 instrumentation that was being logged on every instrumentation of IO.shift and it wasn't caught by neither application_logging.enabled property, nor log_level. This PR fixes it by making this log on Finest level only if it's applicable.

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,

Checks

[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ obenkenobi
❌ mbszarek
You have signed the CLA already but the status is still pending? Let us recheck it.

@tbradellis tbradellis self-assigned this Mar 3, 2023
@tbradellis tbradellis self-requested a review March 3, 2023 15:02
@kford-newrelic
Copy link
Contributor

@mbszarek thanks for the PR! We'll take this up during upcoming PR reviews

@kford-newrelic kford-newrelic added the on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter label Mar 6, 2023
@obenkenobi
Copy link
Contributor

Added commits just to re-trigger GHA as we changed our workflows

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a8c79f7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage        ?   57.86%           
  Complexity      ?     8523           
=======================================
  Files           ?      940           
  Lines           ?    42188           
  Branches        ?     6150           
=======================================
  Hits            ?    24412           
  Misses          ?    15365           
  Partials        ?     2411           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@obenkenobi
Copy link
Contributor

Due to GHA issues due to working from forked PRs atm, this PR will then be moved to a new PR off a non-forked branch.

@obenkenobi obenkenobi merged commit efefbe9 into newrelic:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-roadmap Issue has been added to our product roadmap and will be worked in the coming quarter
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants