PR-1173 Fix cats effect 2 logging #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenkenobi
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1269 +/- ##
=======================================
Coverage ? 57.94%
Complexity ? 8524
=======================================
Files ? 943
Lines ? 42264
Branches ? 6150
=======================================
Hits ? 24491
Misses ? 15363
Partials ? 2410 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
obenkenobi
requested review from
meiao,
jasonjkeller,
tbradellis,
jtduffy and
jbedell-newrelic
jtduffy
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a duplicate of another one.
As such, here is a copy/paste of the PR description:
Overview
In one of previous PRs somebody introduced an info log in CE 2 instrumentation that was being logged on every instrumentation of IO.shift and it wasn't caught by neither
application_logging.enabledproperty, norlog_level. This PR fixes it by making this log on Finest level only if it's applicable.Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[ ] Are your contributions backwards compatible with relevant frameworks and APIs?
[ ] Does your code contain any breaking changes? Please describe.
[ ] Does your code introduce any new dependencies? Please describe.