First pass of J22 support #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
============================================
- Coverage 70.89% 70.79% -0.10%
+ Complexity 9966 9855 -111
============================================
Files 828 821 -7
Lines 39957 39693 -264
Branches 6053 6049 -4
============================================
- Hits 28326 28102 -224
+ Misses 8899 8867 -32
+ Partials 2732 2724 -8 ☔ View full report in Codecov by Sentry. |
jtduffy
commented
Apr 1, 2024
| @@ -6,6 +6,7 @@ plugins { | |||
| } | |||
|
|
|||
| apply from: '../gradle/script/spotbugs-config.gradle' | |||
| apply from: '../gradle/script/jacoco.gradle' | |||
There was a problem hiding this comment.
We apply the new jacooc.gradle script in those modules that we actively want code coverage metrics on.
jtduffy
commented
Apr 1, 2024
| @@ -22,6 +22,10 @@ verifyInstrumentation { | |||
| fails('org.mongodb:mongo-java-driver:[0.9.1,3.1.0-rc0)') | |||
| } | |||
|
|
|||
| test { | |||
| systemProperty "jdk.util.zip.disableZip64ExtraFieldValidation", true | |||
There was a problem hiding this comment.
Java 22 introduced more robust zip file verification, which was failing on this test (and two others). It seems related to how some of the embedded database artifacts were compressed. This setting disables that extra validation.
jbedell-newrelic
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1805