-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass of J22 support #1819
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2cb4b30
First pass of J22 support
jtduffy aa0f831
Correct typo
jtduffy bd65857
Fix version in sed cmd
jtduffy 14a5423
Another typo
jtduffy 699f622
test corrections
jtduffy 554622a
Attempt to disable jacoco for instru modules
jtduffy 07c8436
Attempt to disable jacoco for instru modules part 2
jtduffy 60dd0ea
revert jacoco change
jtduffy 05cda9b
attempt to disable jacoco in instru modules
jtduffy 4a17168
attempt to disable jacoco in instru modules 2
jtduffy 14f903c
another disable attempt
jtduffy 06a54fd
Refactor jacoco into gradle file
jtduffy 458b701
remove jacoco closure from java.gradle
jtduffy 6eaaa30
remove jacoco from monix-api
jtduffy 32f04aa
Try to bypass zipfile validation
jtduffy 35552b8
Disable zip extra field validation
jtduffy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,4 @@ jdk8=8 | |
jdk11=11 | ||
jdk17=17 | ||
jdk21=21 | ||
jdk22=22 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
apply plugin: 'java' | ||
apply plugin: 'jacoco' | ||
|
||
jacoco{ | ||
toolVersion = "0.8.11" | ||
} | ||
|
||
test { | ||
jacoco { | ||
enabled = true | ||
destinationFile = layout.buildDirectory.file('jacoco/test.exec').get().asFile | ||
classDumpDir = layout.buildDirectory.dir('jacoco/classpathdumps').get().asFile | ||
destinationFile = layout.buildDirectory.file("jacoco/${name}.exec").get().asFile | ||
|
||
} | ||
finalizedBy jacocoTestReport // report is always generated after tests run | ||
} | ||
|
||
jacocoTestReport { | ||
|
||
dependsOn test | ||
afterEvaluate { | ||
classDirectories.setFrom(files(classDirectories.files.collect { | ||
fileTree(dir: it, | ||
exclude: ['**/*NoOp*.class', | ||
'**/*Exception.class', | ||
'**/*Error.class', | ||
'**/Dummy*.class', | ||
'**/*Type.class', | ||
'**/*Type$*.class', | ||
'**/*Parameters.class', | ||
'**/*Parameters$*.class', | ||
'com/newrelic/agent/InternalLimitExceeded.class', | ||
'com/newrelic/agent/PrivateApiImpl.class', | ||
'com/newrelic/agent/introspec/*.class', | ||
'com/newrelic/agent/jmx/metrics/*Generator.class', | ||
'com/newrelic/agent/jmx/metrics/*Generator$*.class', | ||
'com/newrelic/agent/bridge/external/ExternalParametersFactory.class', | ||
'com/newrelic/agent/instrumentation/tracing/TraceDetailsBuilder*.class', | ||
'com/newrelic/agent/model/ApdexPerfZone.class', | ||
'com/newrelic/agent/model/CountedDuration.class', | ||
'com/newrelic/agent/model/PathHashes.class', | ||
'com/newrelic/agent/model/SpanCategory.class', | ||
'com/newrelic/agent/model/SyntheticsIds.class', | ||
'com/newrelic/agent/model/TimeoutCause.class', | ||
'com/newrelic/agent/model/TransactionTiming.class', | ||
'com/newrelic/agent/model/TransactionTiming$*.class', | ||
'com/newrelic/api/agent/NewRelic.class', | ||
'com/newrelic/weave/verification/*.class', | ||
'com/newrelic/agent/bridge/datastore/DatastoreMetrics.class', | ||
'com/newrelic/api/agent/ApplicationNamePriority.class', | ||
'com/newrelic/agent/bridge/TransactionNamePriority.class', | ||
'com/newrelic/weave/utils/Synchronized*.class', | ||
'com/newrelic/agent/introspec/internal/IgnoringJarCollectorService.class', | ||
'com/newrelic/agent/introspec/internal/FailingWeavePackageListener.class', | ||
'com/newrelic/agent/tracers/UltraLightTracer.class', | ||
'com/newrelic/agent/core/CoreServiceImpl.class', | ||
'com/newrelic/agent/Deployments.class', | ||
'com/newrelic/agent/LifecycleObserver$*.class', | ||
'com/newrelic/agent/LifecycleObserver.class', | ||
'com/newrelic/agent/InitProblemClasses.class', | ||
'com/newrelic/agent/reinstrument/ReinstrumentUtils.class', | ||
'com/newrelic/agent/AsyncApiImpl.class', | ||
'com/newrelic/agent/tracers/jasper/JasperClassFactory.class', | ||
'com/newrelic/agent/tracers/jasper/GeneratorVisitTracerFactory.class' | ||
]) | ||
})) | ||
} | ||
reports { | ||
xml.required = true | ||
html.outputLocation = layout.buildDirectory.dir('reports/jacoco') | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We apply the new
jacooc.gradle
script in those modules that we actively want code coverage metrics on.