Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.3.1a/6.2 - The headings "Profile picture" and "Profile" have been incorrectly implemented as "label" elements instead of headings - e.g. <label data-v-117e8ad0="">Profile</label>. (1) #41827

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 5 comments · Fixed by #42319
Closed

[BITV] 9.1.3.1a/6.2 - The headings "Profile picture" and "Profile" have been incorrectly implemented as "label" elements instead of headings - e.g. <label data-v-117e8ad0="">Profile</label>. (1) #41827

JuliaKirschenheuter opened this issue Nov 29, 2023 · 5 comments · Fixed by #42319
Assignees
@Pytal
Labels
3. to review Waiting for reviews accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

e.g. <label data-v-117e8ad0="">Profile</label>.

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-be75bbae42-v6-n2
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@paramazo

This comment was marked as off-topic.

Sign in to view
@Pytal Pytal self-assigned this Nov 29, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

Please have a look #36912, need clarification

@ShGKme
Copy link
Contributor

ShGKme commented Dec 1, 2023

This element indeed is not supposed to be a label. Or should be connected to the switch and have a section heading.

image

@Pytal Pytal mentioned this issue Dec 16, 2023
Merged
3 tasks
@Pytal Pytal added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 16, 2023
@Pytal
Copy link
Member

Pytal commented Jan 2, 2024

This is done no @JuliaKirschenheuter? Why is this in Parked?

@ShGKme
Copy link
Contributor

ShGKme commented Jan 2, 2024

This is done no @JuliaKirschenheuter? Why is this in Parked?

Backport was merged just recently, now it can be in done indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): Use heading for Profile and Profile picture sections nextcloud/server
5 participants
@JuliaKirschenheuter @Pytal @ShGKme @szaimen @paramazo