Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Use heading for Profile and Profile picture sections #42319

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 16, 2023

Summary

  • Profile picture has multiple buttons so binding it to one input doesn't make sense
  • Profile checkbox already has a <label>

No visual changes

Checklist

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Dec 16, 2023
@Pytal Pytal added this to the Nextcloud 29 milestone Dec 16, 2023
@Pytal Pytal self-assigned this Dec 16, 2023
@Pytal
Copy link
Member Author

Pytal commented Dec 16, 2023

/backport 711044e to stable28

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@susnux
Copy link
Contributor

susnux commented Dec 22, 2023

drone unrelated

@susnux susnux merged commit 2e6c4eb into master Dec 22, 2023
40 of 41 checks passed
@susnux susnux deleted the fix/a11y/personal-info-headings branch December 22, 2023 17:56
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants