Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: remote share items redirect to incorrect place #47618

Closed
4 of 8 tasks
Antreesy opened this issue Aug 30, 2024 · 1 comment · Fixed by #47665
Closed
4 of 8 tasks

[Bug]: remote share items redirect to incorrect place #47618

Antreesy opened this issue Aug 30, 2024 · 1 comment · Fixed by #47665
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: files

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Aug 30, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Vue component props for remote shares are set incorrectly.

See response from API endpoint:
image

And component props:
image

Click on file redirects to /apps/files/files/2?dir=/&openfile=true instead of /apps/files/files/761?dir=/Shares&openfile=true

Steps to reproduce

  1. Set in Personal settings => Sharing => Set default folder for accepted shares => Set something different from /
  2. Accept remote share from federated server (try this to enable it)
    occ config:system:set sharing.federation.allowSelfSignedCertificates --value true --type bool
    occ config:system:set allow_local_remote_servers --value true --type bool
  3. Check that files appear in "Shared with you" and selected directory
  4. Try to navigate from "Shared with you" to it
  5. See result

Expected behavior

Items should redirect to mountpoint with correct (local) file_id to show a preview

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 28.0.1 to 28.0.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

- cloud_federation_api: 1.11.0
 - federatedfilesharing: 1.18.0
 - federation: 1.18.0
 - files: 2.0.0
 - files_sharing: 1.20.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@Antreesy Antreesy added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: files 28-feedback labels Aug 30, 2024
@Antreesy
Copy link
Contributor Author

cc @susnux as being discussed:

So either the frontend should also consider the file_id property (I think in sharing service?) or the backend for remote shares also should add the file_source property for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant