-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Correctly parse external shares for files UI #47665
Conversation
/backport to stable30 |
/backport to stable29 |
fdfe5aa
to
6bf8c65
Compare
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested! 🥳
6bf8c65
to
02ed6a3
Compare
/compile |
Signed-off-by: Ferdinand Thiessen <[email protected]>
02ed6a3
to
8770e2b
Compare
Signed-off-by: nextcloud-command <[email protected]>
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47665/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable29 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47665/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable30 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
/backport to stable30 |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47665/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8770e2b2 541b2690
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47665/stable30 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..f9a71f3
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Sadly the attributes of internal and external shares are named differently, this adds handling for all remote share attributes so we handle them similar to internal shares.
Checklist