Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use share setting in DAV search #31963

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 13, 2022

shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced in #31932 to ignore second display name during search from the Share panel. But this setting was not respected by search from the calendar application. This fix it.

Same with shareapi_restrict_user_enumeration_full_match_email in #31964.

@artonge artonge added this to the Nextcloud 25 milestone Apr 13, 2022
@artonge artonge self-assigned this Apr 13, 2022
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

lib/public/Share/IManager.php Outdated Show resolved Hide resolved
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the feat/use_setting_in_dav_search branch 3 times, most recently from 8746089 to 3cacb08 Compare April 19, 2022 10:54
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the feat/use_setting_in_dav_search branch from 3cacb08 to e8ab298 Compare April 19, 2022 14:23
@artonge artonge merged commit 7ccfddb into master May 4, 2022
@artonge artonge deleted the feat/use_setting_in_dav_search branch May 4, 2022 11:38
@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable22

@artonge
Copy link
Contributor Author

artonge commented May 9, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@artonge
Copy link
Contributor Author

artonge commented May 11, 2022

/backport to stable24

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

* Check if the search should match the email
*
* @return bool
* @since 25.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24.0.1

Copy link
Contributor Author

@artonge artonge Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix here: #32739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants