Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @since comment in IManager #32739

Closed
wants to merge 1 commit into from
Closed

Fix @since comment in IManager #32739

wants to merge 1 commit into from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 7, 2022

The methods will be backported to 23 and 22 but PR are still pending. I'll create a new PR to update the @since when they get merged.

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge added this to the Nextcloud 25 milestone Jun 7, 2022
@artonge artonge requested review from ChristophWurst and a team June 7, 2022 11:27
@artonge artonge self-assigned this Jun 7, 2022
@artonge artonge requested review from blizzz, juliusknorr and CarlSchwan and removed request for a team June 7, 2022 11:27
@artonge
Copy link
Contributor Author

artonge commented Jun 7, 2022

/backport to stable24

Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this, the api was added in 25 and an app that wants to use that should target 25. We can't specify in an appinfo.xml that an app is only available for 24.0.1

@ChristophWurst
Copy link
Member

We can't specify in an appinfo.xml that an app is only available for 24.0.1

#9024 😈

@blizzz
Copy link
Member

blizzz commented Jul 5, 2022

imo it is sufficient to have this only in the stable branch. otherwise, you won't not know what the proper version are in 23 and 24 if only the version of 22 remains.

This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@ChristophWurst ChristophWurst deleted the fix/since_comment branch October 17, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants