Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar new style #33752

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Avatar new style #33752

merged 4 commits into from
Sep 9, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 30, 2022

Dark theme: image

White theme:
image
image

Also fix a bug where the avatars where not generated with imagick because the font path was not correct

Todos:

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real nice! :)

version.php Outdated Show resolved Hide resolved
core/Controller/AvatarController.php Outdated Show resolved Hide resolved
core/Controller/GuestAvatarController.php Outdated Show resolved Hide resolved
lib/private/Avatar/Avatar.php Outdated Show resolved Hide resolved
lib/private/Avatar/Avatar.php Show resolved Hide resolved
Signed-off-by: Carl Schwan <[email protected]>
And better caching policy

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the avatar-new-style branch 2 times, most recently from aea3d11 to 61ee0d9 Compare September 9, 2022 12:11
Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan
Copy link
Member Author

ci failure unrelated (sharing)

@CarlSchwan CarlSchwan merged commit 4a82396 into master Sep 9, 2022
@CarlSchwan CarlSchwan deleted the avatar-new-style branch September 9, 2022 13:01
@blizzz blizzz mentioned this pull request Sep 9, 2022
@ChristophWurst
Copy link
Member

This should be documented so apps can adjust. I still see

{"reqId":"wfo0ZhmZNBDzXGliaakN","level":0,"time":"2023-01-26T09:32:37+00:00","remoteAddr":"127.0.0.1","user":"admin","app":"core","method":"GET","url":"/avatar/admin/32?v=4","message":"Avatar requested in deprecated size 32","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0","version":"26.0.0.2","data":{"app":"core"}}

in my log when I open Dashboard

@ChristophWurst
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants