Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to dark/light themed server-side avatars with v25 #2409

Open
AndyScherzinger opened this issue Sep 20, 2022 · 3 comments
Open

Adapt to dark/light themed server-side avatars with v25 #2409

AndyScherzinger opened this issue Sep 20, 2022 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Sep 20, 2022

see nextcloud/server#33752 introducing dark/light avatars, so the clients would need to requests them based on the theme and cache dark and light variants. @CarlSchwan since you brought this to life, if somebody is setting a custom avatar then there is just one, so there is no need for dark/light but unsure if that is detectable or if we need to live with that and cache an avatar twice.

current behaviour in dark mode is:
image
these light avatars must be replaced with dark ones

@mahibi mahibi added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) and removed 0. Needs triage labels Sep 26, 2022
@provokateurin provokateurin self-assigned this Oct 1, 2022
@provokateurin
Copy link
Member

Since there is no cache in the app right now don't need to care about caching twice.

@nickvergessen
Copy link
Member

if somebody is setting a custom avatar then there is just one, so there is no need for dark/light but unsure if that is detectable or if we need to live with that and cache an avatar twice.

/dark also returns the custom avatar ready to display. So you don't need to check and distinguish

@provokateurin provokateurin removed their assignment Oct 21, 2022
@AndyXheli
Copy link

AndyXheli commented Jan 27, 2024

Dark avatars show up under individual chats but not under the main chat screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants