-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No implicit any errors #15
Comments
timruffles
added a commit
to timruffles/core
that referenced
this issue
Mar 31, 2017
Since this module is designed to be compiled by consumer projects (from what I can tell - see ngrx#15), it's nice to turn on noImplicitAny. The compose function had a signature, but tsc didn't seem to be able to infer the argument types. I've added them, and checked that `ComposeSignature` is still the type consumers see. Fixes ngrx#15.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm having the following errors:
when using this repo with: Typescript 2.2.2 and the below tsconfig. From looking at the code there is a type annotation, but TS seems to be failing at inferring the types from it.
I've not dug into best-practices for publishing TS modules, but is the lack of explicit declaration file in
package.json
, or aindex.d.ts
forcing TypeScript to dig through the package and re-validate it? I note the TypeScript docs suggests eithertypes
inpackage.json
or aindex.d.ts
(the approach Angular itself takes).The text was updated successfully, but these errors were encountered: