turn on noImplicitAny #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this module is designed to be compiled by consumer projects (from what I can tell - see ngrx#15), it's nice to turn on noImplicitAny. The compose function had a signature, but tsc didn't seem to be able to infer the argument types. I've added them, and checked that `ComposeSignature` is still the type consumers see. Fixes ngrx#15.
|
Closing as project seems quiet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this module is designed to be compiled by consumer projects (from what I can tell - see #15), it's nice to turn on
noImplicitAnyso those usingnoImplicitAnydon't suffer compiler warnings.The compose function had a signature, but
tscdidn't seem to be able to infer its argument types so considers them implicitly any. I've added annotations, and checked thatComposeSignatureis still the type consumers see.I'm now using this commit in my project, and the compiler warnings have thankfully ceased 🎉
Fixes #15.