feat(component): remove LetModule
#4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE:
The `LetModule` is removed in favor of the standalone `LetDirective`.
BEFORE:
```ts
import { LetModule } from '@ngrx/component';
@NgModule({
imports: [
// ... other imports
LetModule,
],
})
export class MyFeatureModule {}
```
AFTER:
```ts
import { Component } from '@angular/core';
import { LetDirective } from '@ngrx/component';
@component({
// ... other metadata
standalone: true,
imports: [
// ... other imports
LetDirective,
],
})
export class MyStandaloneComponent {}
```
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timdeschryver
commented
Oct 21, 2023
| @@ -33,7 +33,6 @@ module.exports = new Package('angular-api', [basePackage, typeScriptPackage]) | |||
| .processor(require('./processors/computeStability')) | |||
| .processor(require('./processors/removeInjectableConstructors')) | |||
| .processor(require('./processors/processPackages')) | |||
| .processor(require('./processors/processNgModuleDocs')) | |||
There was a problem hiding this comment.
Removed because otherwise we'll get an error during the build, e.g.
7:33:20 PM: error: "component/LetDirective" has no @ngModule tag. Docs of type "directive" must have this tag. - doc "component/LetDirective" (directive) - from file "component/src/let/let.directive.ts" - starting at line 34, ending at line 227
7:33:20 PM: error: Error running processor "processNgModuleDocs":
brandonroberts
approved these changes
Oct 24, 2023
markostanimirovic
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4077
What is the new behavior?
Does this PR introduce a breaking change?
BREAKING CHANGE:
The
LetModuleis removed in favor of the standaloneLetDirective.BEFORE:
AFTER:
Other information