Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): remove LetModule #4087

Merged
merged 5 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions modules/component/spec/let/let.module.spec.ts

This file was deleted.

1 change: 0 additions & 1 deletion modules/component/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export { RenderScheduler } from './core/render-scheduler';
export { LetDirective } from './let/let.directive';
export { LetModule } from './let/let.module';
export { PushPipe } from './push/push.pipe';
export { PushModule } from './push/push.module';
1 change: 0 additions & 1 deletion modules/component/src/let/let.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ export interface LetViewContext<PO> {
}

/**
* @ngModule LetModule
*
* @description
*
Expand Down
11 changes: 0 additions & 11 deletions modules/component/src/let/let.module.ts

This file was deleted.

8 changes: 0 additions & 8 deletions projects/ngrx.io/content/guide/component/let.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,6 @@ import { LetDirective } from '@ngrx/component';
export class MyStandaloneComponent {}
```

<div class="alert is-critical">

The `*ngrxLet` directive can be also used by importing the `LetModule`.
However, the `LetModule` is deprecated in favor of the standalone `LetDirective`.
See the [migration guide](guide/migration/v16#letmodule) for more information.

</div>

## Comparison with `*ngIf` and `async`

The current way of binding an observable to the view looks like this:
Expand Down
2 changes: 1 addition & 1 deletion projects/ngrx.io/content/guide/migration/v15.md
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ The `MinimalActivatedRouteSnapshot` interface contains the required `title` prop

#### Removal of ReactiveComponentModule

The `ReactiveComponentModule` is removed in favor of [`LetModule`](/api/component/LetModule) and [`PushModule`](/api/component/PushModule).
The `ReactiveComponentModule` is removed in favor of `LetModule` and [`PushModule`](/api/component/PushModule).

BEFORE:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module.exports = new Package('angular-api', [basePackage, typeScriptPackage])
.processor(require('./processors/computeStability'))
.processor(require('./processors/removeInjectableConstructors'))
.processor(require('./processors/processPackages'))
.processor(require('./processors/processNgModuleDocs'))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because otherwise we'll get an error during the build, e.g.

7:33:20 PM: error:   "component/LetDirective" has no @ngModule tag. Docs of type "directive" must have this tag. - doc "component/LetDirective" (directive)  - from file "component/src/let/let.directive.ts" - starting at line 34, ending at line 227
7:33:20 PM: error:   Error running processor "processNgModuleDocs":

.processor(require('./processors/fixupRealProjectRelativePath'))


Expand Down

This file was deleted.

This file was deleted.