Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement fallback address #12

Merged
merged 4 commits into from
May 10, 2024
Merged

feat: implement fallback address #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a447d0
feat: implement fallback address
johnletey May 6, 2024
2888dca
chore: changelog entry
johnletey May 6, 2024
5a2cd30
chore: sync main
johnletey May 9, 2024
f9af6be
chore: add clearing tests
johnletey May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/unreleased/features/12-fallback-address.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Support an optional fallback address for easy recovery of funds. ([#12](https:/noble-assets/forwarding/pull/12))
2 changes: 1 addition & 1 deletion .github/workflows/e2e-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ jobs:
run: docker image load -i ${{ env.TAR_PATH }}

- name: run test
run: cd e2e && go test -race -v -timeout 30m -run ^${{ matrix.test }}$ .
run: cd e2e && go test -race -v -timeout 15m -run ^${{ matrix.test }}$ .
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ test: test-e2e

test-e2e:
@echo "🤖 Running e2e tests..."
@cd e2e && go test -race -v ./...
@cd e2e && go test -timeout 15m -race -v ./...
@echo "✅ Completed e2e tests!"
110 changes: 92 additions & 18 deletions api/noble/forwarding/v1/account.pulsar.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading