test: add stdin-setrawmode.out file to accompany test #10146
Conversation
Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js. The test was originally merged without this file and an astute observer found that it was causing an error message. See discussion at nodejs#10037.
|
Very strange, it's passing on my machine. Doing a full rebuild now in an effort to get it failing locally. |
|
Hmm, looks like this is popping up on some platforms: |
Are you running it through the test runner, or are you just executing the file? You will want to execute |
|
The test passes fine for me now on OS X 10.10.5 |
|
I'm running it with Unfortunately, it's still passing for me after a fresh build using both |
|
Yeah, sorry, my bad. Inside of CI, stdin is currently not a TTY, even for the pseudo-tty tests… sigh |
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
marking |
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #10037 Ref: #10146 PR-URL: #10149 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Adds an accompanying .out file for test/pseudo-tty/stdin-setrawmode.js.
The test was originally merged without this file and an astute
observer found that it was causing an error message. See discussion
at #10037.