Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-net-write-slow #7555

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 6, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change

Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516

Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: nodejs#7516
@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Jul 6, 2016
@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

(Still kind of wonder if the test shouldn't be removed, though. See #7516 for archeological and other details.)

@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

CI is green.

@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

@nodejs/testing

@mscdex
Copy link
Contributor

mscdex commented Jul 6, 2016

What about changing the timeout value based on os.platform() or something?

@addaleax addaleax mentioned this pull request Jul 6, 2016
@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

@mscdex That's an option, but I don't think it's preferable in this situation. The arbitrarily large value doesn't make the test take any longer to pass. If it affected the test duration, I'd be inclined to tune the value based on platform. But since it doesn't affect execution time on successful tests, I'd prefer to avoid the complexity of different values on different platforms.

@Trott
Copy link
Member Author

Trott commented Jul 6, 2016

This FreeBSD failure on CI is starting to get a little out of control, so I'm going to try to raise the profile of this fix and argue for an expedited landing (small change, big positive impact, easy to revert, doesn't affect userland code). Raising profile: @nodejs/collaborators

@mcollina
Copy link
Member

mcollina commented Jul 6, 2016

LGTM

@santigimeno
Copy link
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jul 7, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: nodejs#7516
PR-URL: nodejs#7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 7, 2016

Landed in 9d654a3. Goodbye, red FreeBSD CI.

@Trott Trott closed this Jul 7, 2016
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
Increase socket timeout so that there is enough time to reliably run the
test on FreeBSD.

Fixes: #7516
PR-URL: #7555
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@Trott Trott deleted the slowrite branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freebsd Issues and PRs related to the FreeBSD platform. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants