test: fix flaky test/fs-read-buffer-tostring-fail #7575
Conversation
Trott
added
fs
The test is memory intensive and times out occasionally on Raspberry Pi devices in CI. Successful test runs take about 90 seconds, but the devices time out after 120 seconds. That's not a lot of headroom. So let's skip the test on devices that have only modest amounts of memory. Fixes: nodejs#7042
| @@ -1,6 +1,13 @@ | |||
| 'use strict'; | |||
|
|
|||
| const common = require('../common'); | |||
|
|
|||
| const skipMessage = 'intensive toString tests due to memory confinements'; | |||
There was a problem hiding this comment.
Doesn't there need to be a header here or something, like the other tests that have a similar skip message?
There was a problem hiding this comment.
I'm not sure what you mean. Here's another example:
And here's what this test pass when it skips:
1..0 # Skipped: intensive toString tests due to memory confinements
There was a problem hiding this comment.
I guess I'll run CI and see what happens on the Raspberry Pi devices...
There was a problem hiding this comment.
Nevermind, I didn't realize .skip() was adding the necessary header.
|
Only CI failure is known FreeBSD flaky test. (How is everyone not LGTM-ing the crud out of #7555 to get that fixed?) |
|
Raspberry Pis in CI seem to skip correctly: That output format matches other skipped tests, such as: Meanwhile, the test is not skipped on (for example) OS X: I think this is good to go. |
|
lgtm, seems like the sensible way to go |
|
lgtm |
|
LGTM |
The test is memory intensive and times out occasionally on Raspberry Pi devices in CI. Successful test runs take about 90 seconds, but the devices time out after 120 seconds. That's not a lot of headroom. So let's skip the test on devices that have only modest amounts of memory. Fixes: nodejs#7042 PR-URL: nodejs#7575 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
|
Landed in b9b49ee |
|
@Trott lts? |
|
@thealphanerd Yes if it lands cleanly and CI passes. |
The test is memory intensive and times out occasionally on Raspberry Pi devices in CI. Successful test runs take about 90 seconds, but the devices time out after 120 seconds. That's not a lot of headroom. So let's skip the test on devices that have only modest amounts of memory. Fixes: #7042 PR-URL: #7575 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test fs
Description of change
The test is memory intensive and times out occasionally on Raspberry Pi
devices in CI. Successful test runs take about 90 seconds, but the
devices time out after 120 seconds. That's not a lot of headroom. So
let's skip the test on devices that have only modest amounts of memory.