Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): mark github releases as pre-release #1152

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Apr 14, 2023

Related issue(s)

Resolves #

Description

Summary of changes

This marks the GitHub Release that is produced by Release-Please as a "Pre-release" (see https:/phated/phated/releases for an example).

Noirup and our various guides utilize the "latest" release because GitHub provides a handy redirect: https:/noir-lang/noir/releases/latest and sometimes the docs and demos lag behind. This change allows the previous release to be marked as "latest" until we manually update the GitHub Release to be latest (such as when documentation is done).

Note: In the PR that added this feature on Release-Please, they restricted it to 0.x.x versions, which would not work for our workflow after 1.0; however, I think this decision was arbitrary and I'll work with them to allow this to be applied to any release versions.

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Documentation needs

  • This PR requires documentation updates when merged.

Additional context

@kevaundray kevaundray added this pull request to the merge queue Apr 14, 2023
Merged via the queue into master with commit 106a0bf Apr 14, 2023
@kevaundray kevaundray deleted the phated/rp-prerelease branch April 14, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants